Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating client license to clear, MIT #2669

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updating client license to clear, MIT #2669

wants to merge 2 commits into from

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Aug 9, 2023

This pull request exists to unify all of our clients until the MIT license. In the case of some repositories this is more permissive, than the prior BSD-3-Clause.

@chayim chayim requested a review from uglide August 9, 2023 12:46
LICENSE Outdated
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:
Copyright (c) 2022-2023, Redis, inc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uglide ? I was just lining things up... Someone help me - I am opinion free here - this is just a copy/paste from redis-py

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chayim we shouldn't change the copyright. The aim is to align all clients under Redis org to the same MIT license.

@vmihailenco you are the copyright owner for most of the code. Is it something that you can consider? Both licenses are permissive, true-OSS.

Copy link
Collaborator

@vmihailenco vmihailenco Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I am concerned the MIT license is fine, but the copyright should stay the same.

"The Authors" means the people who contributed the code (which includes Redis, inc.). Maintainers change with time and don't have anything to do with this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks @vmihailenco . Learned a lot along the way, and apologies if I ruffled any feathers! Changes restored - please let me know what I got wrong :(

@vmihailenco
Copy link
Collaborator

You can't "just" change the license while also transferring the copyright.

Copy link

@uglide uglide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes to copyright

@chayim
Copy link
Contributor Author

chayim commented Aug 10, 2023

Please revert changes to copyright

Got it - thanks. Live + learn. Question @vmihailenco @uglide one of the things we discussed was "Copyright, the maintainers of this library" is that reasonable? Am I overthinking all of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants