-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating client license to clear, MIT #2669
base: master
Are you sure you want to change the base?
Conversation
LICENSE
Outdated
Redistribution and use in source and binary forms, with or without | ||
modification, are permitted provided that the following conditions are | ||
met: | ||
Copyright (c) 2022-2023, Redis, inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uglide ? I was just lining things up... Someone help me - I am opinion free here - this is just a copy/paste from redis-py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chayim we shouldn't change the copyright. The aim is to align all clients under Redis org to the same MIT license.
@vmihailenco you are the copyright owner for most of the code. Is it something that you can consider? Both licenses are permissive, true-OSS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I am concerned the MIT license is fine, but the copyright should stay the same.
"The Authors" means the people who contributed the code (which includes Redis, inc.). Maintainers change with time and don't have anything to do with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - thanks @vmihailenco . Learned a lot along the way, and apologies if I ruffled any feathers! Changes restored - please let me know what I got wrong :(
You can't "just" change the license while also transferring the copyright. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert changes to copyright
Got it - thanks. Live + learn. Question @vmihailenco @uglide one of the things we discussed was "Copyright, the maintainers of this library" is that reasonable? Am I overthinking all of this? |
This pull request exists to unify all of our clients until the MIT license. In the case of some repositories this is more permissive, than the prior BSD-3-Clause.