Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat+test: nic attribute modification #392

Closed

Conversation

dominikvagner
Copy link
Contributor

connected to: #385

After extensive testing on my part and a joint investigation with @grafuls, this feature cannot be fully implemented in the current state of our lab, because of our iDRAC setup/versions.
Getting a list of attributes for specific NICs is working as it should along with getting information about a specific attribute. (The same way as we do it for BIOS attributes.)
Setting attributes though does not work, even if the somewhat incomplete feeling iDRAC documentation about this use case says it should for versions 5.x.x.x (testing was done against 5.10.50.0 as the newest version available to us).
Neither my attempt at solving this or the reference script from Dell works.
In our case the end-point accepting the setting of attributes shows no supported attributes to set.

The getting functionality was implemented and tested. The setting of attributes was made as a draft implementation supposed to completed in the future, when the environment will allow for it.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (5a22209) 91.21% compared to head (c829d7d) 88.57%.
Report is 2 commits behind head on development.

Files Patch % Lines
src/badfish/main.py 56.90% 78 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #392      +/-   ##
===============================================
- Coverage        91.21%   88.57%   -2.64%     
===============================================
  Files                5        5              
  Lines             2174     2355     +181     
===============================================
+ Hits              1983     2086     +103     
- Misses             191      269      +78     
Flag Coverage Δ
unittests 88.57% <56.90%> (-2.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sadsfae sadsfae added the enhancement New feature or request label Feb 12, 2024
@sadsfae sadsfae requested a review from grafuls February 12, 2024 19:45
@sadsfae
Copy link
Member

sadsfae commented Feb 13, 2024

@grafuls should we look to merge this through our branches to release?

@grafuls
Copy link
Collaborator

grafuls commented Feb 26, 2024

Don't want to merge this until we test with a greater FW version than 5.10.50.0 since by our findings with @dominikvagner this doesn't work there.
Parked till the next FW update.

@grafuls
Copy link
Collaborator

grafuls commented Jul 3, 2024

Closing in lieu of PR #402 which includes test fixes and documentation

@grafuls grafuls closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants