Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Remove the last usage of obsolete package #1102

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

baijum
Copy link
Member

@baijum baijum commented Feb 15, 2022

The github.com/pkg/errors package is no more maintaned:
pkg/errors#245

Signed-off-by: Baiju Muthukadan [email protected]

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • Follows the commit message standard

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #1102 (5ff0e92) into master (f626241) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1102   +/-   ##
=======================================
  Coverage   58.92%   58.92%           
=======================================
  Files          30       30           
  Lines        1670     1670           
=======================================
  Hits          984      984           
  Misses        560      560           
  Partials      126      126           
Impacted Files Coverage Δ
pkg/binding/annotationmapper.go 87.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f626241...5ff0e92. Read the comment docs.

@baijum
Copy link
Member Author

baijum commented Mar 17, 2022

/test 4.11-acceptance

@pmacik
Copy link
Contributor

pmacik commented Mar 21, 2022

/retest

@pmacik
Copy link
Contributor

pmacik commented Mar 21, 2022

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmacik
Copy link
Contributor

pmacik commented Mar 21, 2022

/retest

@pmacik
Copy link
Contributor

pmacik commented Mar 22, 2022

@baijum please rebase on top of the current master to rebuild-the images for acceptance tests to match the acceptance tests scenarios. Otherwise, the acceptance tests would keep failing.

The github.com/pkg/errors package is no more maintaned:
pkg/errors#245

Signed-off-by: Baiju Muthukadan <[email protected]>
@pmacik
Copy link
Contributor

pmacik commented Mar 22, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 22, 2022
@baijum
Copy link
Member Author

baijum commented Mar 22, 2022

/retest

7 similar comments
@pmacik
Copy link
Contributor

pmacik commented Mar 22, 2022

/retest

@pmacik
Copy link
Contributor

pmacik commented Mar 22, 2022

/retest

@pmacik
Copy link
Contributor

pmacik commented Mar 22, 2022

/retest

@pmacik
Copy link
Contributor

pmacik commented Mar 22, 2022

/retest

@pmacik
Copy link
Contributor

pmacik commented Mar 22, 2022

/retest

@baijum
Copy link
Member Author

baijum commented Mar 23, 2022

/retest

@pmacik
Copy link
Contributor

pmacik commented Mar 23, 2022

/retest

@openshift-merge-robot openshift-merge-robot merged commit ddc725f into redhat-developer:master Mar 23, 2022
@baijum baijum deleted the pkg-errors branch November 11, 2022 04:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants