Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(set_workflow_status): validate endpoint arguments (#589) #589

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

mdonadoni
Copy link
Member

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.35%. Comparing base (1dc2116) to head (25a24fc).
Report is 2 commits behind head on maint-0.9.

Current head 25a24fc differs from pull request most recent head 0e32f8e

Please upload reports for the commit 0e32f8e to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           maint-0.9     #589      +/-   ##
=============================================
- Coverage      73.41%   73.35%   -0.06%     
=============================================
  Files             15       15              
  Lines           1369     1370       +1     
=============================================
  Hits            1005     1005              
- Misses           364      365       +1     
Files Coverage Δ
reana_workflow_controller/config.py 100.00% <100.00%> (ø)
...na_workflow_controller/rest/workflows_workspace.py 61.02% <ø> (ø)
reana_workflow_controller/version.py 100.00% <100.00%> (ø)
reana_workflow_controller/k8s.py 88.13% <50.00%> (-0.66%) ⬇️
reana_workflow_controller/rest/utils.py 81.98% <60.00%> (+0.19%) ⬆️
reana_workflow_controller/rest/workflows_status.py 81.92% <80.00%> (-1.21%) ⬇️

mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request Jun 26, 2024
@mdonadoni mdonadoni marked this pull request as ready for review June 26, 2024 10:21
@mdonadoni mdonadoni changed the base branch from master to maint-0.9 July 2, 2024 07:59
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request Jul 2, 2024
@@ -1116,19 +1116,30 @@
"type": "string"
},
{
"description": "Optional. Additional input parameters and operational options for workflow execution. Possible parameters are `CACHE=on/off`, passed to disable caching of results in serial workflows, `all_runs=True/False` deletes all runs of a given workflow if status is set to deleted and `workspace=True/False` which deletes the workspace of a workflow.",
"description": "Optional. Additional parameters to customise the change of workflow status.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional. Additional parameters to customise the workflow status change.

"type": "boolean"
},
"input_parameters": {
"description": "Optional. Additional input parameters that override the ones in the workflow specification. Only allowed when status is `start`.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional. Additional input parameters that override the ones from the workflow specification. Only allowed when status is start.

"type": "object"
},
"operational_options": {
"description": "Optional. Operational options for workflow execution. Only allowed when status is `start`.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional. Additional operational options for workflow execution. Only allowed when status is start.

"type": "object"
},
"restart": {
"description": "Optional. If true, the workflow is a restart of another one. Only allowed when status is `start`.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional. If true, the workflow is a restart of an earlier workflow execution. Only allowed when status is start.

type: string
operational_options:
description: >-
Optional. Operational options for workflow execution.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments to the description verbiage alluded to above.

@mdonadoni mdonadoni merged commit 5945d7f into reanahub:maint-0.9 Jul 3, 2024
12 checks passed
@mdonadoni mdonadoni deleted the parameters-start-workflow branch July 3, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reana-client download fails for workflows with files as None is not of type 'object'
2 participants