-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(set_workflow_status): validate endpoint arguments (#589) #589
fix(set_workflow_status): validate endpoint arguments (#589) #589
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## maint-0.9 #589 +/- ##
=============================================
- Coverage 73.41% 73.35% -0.06%
=============================================
Files 15 15
Lines 1369 1370 +1
=============================================
Hits 1005 1005
- Misses 364 365 +1
|
aa993b2
to
25a24fc
Compare
25a24fc
to
0e32f8e
Compare
docs/openapi.json
Outdated
@@ -1116,19 +1116,30 @@ | |||
"type": "string" | |||
}, | |||
{ | |||
"description": "Optional. Additional input parameters and operational options for workflow execution. Possible parameters are `CACHE=on/off`, passed to disable caching of results in serial workflows, `all_runs=True/False` deletes all runs of a given workflow if status is set to deleted and `workspace=True/False` which deletes the workspace of a workflow.", | |||
"description": "Optional. Additional parameters to customise the change of workflow status.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional. Additional parameters to customise the workflow status change.
docs/openapi.json
Outdated
"type": "boolean" | ||
}, | ||
"input_parameters": { | ||
"description": "Optional. Additional input parameters that override the ones in the workflow specification. Only allowed when status is `start`.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional. Additional input parameters that override the ones from the workflow specification. Only allowed when status is start
.
docs/openapi.json
Outdated
"type": "object" | ||
}, | ||
"operational_options": { | ||
"description": "Optional. Operational options for workflow execution. Only allowed when status is `start`.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional. Additional operational options for workflow execution. Only allowed when status is start
.
docs/openapi.json
Outdated
"type": "object" | ||
}, | ||
"restart": { | ||
"description": "Optional. If true, the workflow is a restart of another one. Only allowed when status is `start`.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional. If true, the workflow is a restart of an earlier workflow execution. Only allowed when status is start
.
type: string | ||
operational_options: | ||
description: >- | ||
Optional. Operational options for workflow execution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments to the description verbiage alluded to above.
0e32f8e
to
5945d7f
Compare
Closes reanahub/reana-client#718