Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow-details): make step labels less prominent (#397) #397

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

giuseppe-steduto
Copy link
Member

Closes #352

Note: dependant on #394

@mdonadoni
Copy link
Member

Old UI:
immagine

New UI:
immagine

Changes in this PR:
a. bigger badges
b. job duration is moved inside the job selection menu
c. status label is now "basic" (white background instead of green/other color)

I would personally keep only (c), while reverting back (a) and (b), like this:
immagine

What do you think @tiborsimko?

@mdonadoni mdonadoni force-pushed the badges-redesign/step-label-less-prominent branch from dca1ff7 to 13ab9c3 Compare August 9, 2024 13:11
@mdonadoni
Copy link
Member

PS: I have rebased the PR on top of master

@tiborsimko
Copy link
Member

tiborsimko commented Aug 19, 2024

What do you think @tiborsimko?

Agreed about (a) and (c).

WRT (b) the idea behind old discussions to explore moving the timing information to the selection box was that the "finished" would also moved there, so to speak, and not stay outside. Basically, the selection box would show the step name prominently and after it, in parentheses, whether it is running or finished, and its duration. Hence the middle screenshot does not fully cover these ideas, since part of the information is left outside the selection box. At this stage of things, I agree that the third screenshot is preferable to the second.

P.S. Also, WRT release news, instead of fix(workflow-details): make step labels less prominent it may be better to use something like feat(workflow-details): redesign subtler step duration badge (if 72 chars permit) as per the other commit we had about UI redesigning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wf-details: make label for step status more visually balanced
3 participants