Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: fix graceful shutdown of start-scheduler #629

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

mdonadoni
Copy link
Member

Handle SIGTERM in start-scheduler to gracefully stop consuming
the workflow submission queue.

Closes reanahub/reana-job-controller#347

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #629 (9326dda) into master (7e84d56) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
- Coverage   59.50%   59.41%   -0.10%     
==========================================
  Files          32       32              
  Lines        3289     3294       +5     
==========================================
  Hits         1957     1957              
- Misses       1332     1337       +5     
Files Coverage Δ
reana_server/cli.py 0.00% <0.00%> (ø)

Copy link
Member

@giuseppe-steduto giuseppe-steduto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Just needs a rebase

Handle SIGTERM in `start-scheduler` to gracefully stop consuming
the workflow submission queue.

Closes reanahub/reana-job-controller#347
@mdonadoni mdonadoni merged commit 9326dda into reanahub:master Sep 26, 2023
11 checks passed
@mdonadoni mdonadoni deleted the graceful-shutdown branch September 26, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

job controller doesn't respect graceful shutdown send by k8s
2 participants