workflow: always upload REANA specification on create and restart #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VMois
force-pushed
the
upload-specification-by-default
branch
2 times, most recently
from
c7a9892
to
b96b97b
Compare
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
==========================================
+ Coverage 57.37% 57.40% +0.03%
==========================================
Files 23 23
Lines 2299 2303 +4
==========================================
+ Hits 1319 1322 +3
- Misses 980 981 +1
|
VMois
commented
Aug 16, 2022
reana_client/cli/workflow.py
Outdated
| parsed_parameters["reana_specification"] = load_validate_reana_spec( | ||
| click.format_filename(file) | ||
| ) | ||
| if workflow: |
There was a problem hiding this comment.
workflow must always exist, so I removed this check.
audrium
force-pushed
the
upload-specification-by-default
branch
from
5ce2147
to
6f0657d
Compare
|
Because of my mistake the original PR got closed, I've pushed the same rebased commit here: #647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #623