Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python): add support for Python 3.13 (#136) #136

Merged

Conversation

jlemesh
Copy link
Member

@jlemesh jlemesh commented Oct 9, 2024

Closes reanahub/reana#837

Add support for Python 3.13.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.64%. Comparing base (40d3c6e) to head (7ce8c29).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #136   +/-   ##
======================================
  Coverage    3.64%   3.64%           
======================================
  Files           5       5           
  Lines         274     274           
======================================
  Hits           10      10           
  Misses        264     264           

jlemesh added a commit to jlemesh/pytest-reana that referenced this pull request Oct 9, 2024
@jlemesh jlemesh force-pushed the feature_add_support_for_python313 branch from 450be86 to 4a380a7 Compare October 9, 2024 12:47
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetics: Please capitalise Python in the commit log headline. Also, this change does not really concern only CI, but the client package functionality too, especially when you think of reana-commons and reana-client. Hence the scope would be better build(python) .

For example, see a past commit here:

build(python): drop support for Python 3.6 and 3.7 

This would call for using:

build(python): add support for Python 3.13

@tiborsimko
Copy link
Member

build(python): add support for Python 3.13

P.S. You can also add Closes reanahub/reana#837 to the commit message body in order to keep the PRs linked to the issue.

@jlemesh jlemesh force-pushed the feature_add_support_for_python313 branch from 4a380a7 to 7ce8c29 Compare October 10, 2024 07:05
@jlemesh jlemesh changed the title ci(actions): add support for python 3.13 (#136) build(python): add support for Python 3.13 (#136) Oct 10, 2024
@tiborsimko tiborsimko merged commit 7ce8c29 into reanahub:master Oct 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: start testing Python 3.13
2 participants