feat: change IPerformanceService
to return HttpResponseMessage
#1893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change return types from
Task<string>
toTask<HttpResponseMessage
. This makes the benchmarks more accurate as they are intended to measure the cost of configuring and sending aHttpRequestMessage
and not the time taken to convert the response into astring
.On a related note why isn't refit using
ReadAsStringAsync
?New Benchmark
Old