feat: add ReflectionTests for IUrlParameterFormatter
#1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1888 +/- ##
==========================================
- Coverage 87.73% 84.28% -3.45%
==========================================
Files 33 36 +3
Lines 2348 2476 +128
Branches 294 347 +53
==========================================
+ Hits 2060 2087 +27
- Misses 208 310 +102
+ Partials 80 79 -1 ☔ View full report in Codecov by Sentry. |
TimothyMakkison
force-pushed
the
reflection_test
branch
from
1a5f7b0
to
42177d4
Compare
TimothyMakkison
force-pushed
the
reflection_test
branch
2 times, most recently
from
48f768b
to
67a0e16
Compare
TimothyMakkison
force-pushed
the
reflection_test
branch
from
67a0e16
to
af906ff
Compare
ChrisPulman
approved these changes
Oct 23, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a reflection test to verify the types of
ICustomAttributeProviderandTypearguments provided toIUrlParameterFormatter.Format.This is to prevent me from breaking anything while I rewrite the generator to provide these values as fields at compile time.