Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: kysely fails #70

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Hotfix: kysely fails #70

merged 1 commit into from
Sep 5, 2024

Conversation

vcarl
Copy link
Member

@vcarl vcarl commented Sep 5, 2024

ERROR  Cannot find module './app/db.server'
Require stack:
- /app/kysely.config.ts

Can't import app code in config files

@vcarl vcarl merged commit 2c86275 into main Sep 5, 2024
@vcarl vcarl deleted the vc-hotfix-again branch September 5, 2024 23:17
Copy link

what-the-diff bot commented Sep 5, 2024

PR Summary

  • Introduction of better-sqlite3 and kysely libraries
    The team has added two libraries to the project: 'better-sqlite3', which allows for better interaction with SQLite databases, and 'kysely', a library designed for making querying databases more intuitive and efficient.

  • Modification of Database Dialect
    The method to interact with the database has been modified. Instead of importing a predetermined dialect from the application's server file, the code now creates a new instance of SqliteDialect from the 'kysely' library, connecting it directly to our SQLite database specified by the DATABASE_URL. This change modernizes the way we handle database interactions, leading to a more efficient and potentially faster runtime.

@vcarl vcarl mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant