Fix this.unmounted being true when re-mounted by React 18
#480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React 18 can render componentWillUnmount and then componentDidMount the same instance that was just "willUnmount"-ed. This makes sure we reset `this.unmounted = false` when re-didMount-ing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand that you are spending your time now on React Router v6, but it would be very nice to have this in still.
This one line change made my app go from "Reach Router not doing anything at all" to working perfectly on React 18.
React 18 can render componentWillUnmount and then componentDidMount the same instance that was just "willUnmount"-ed.
This makes sure we reset
this.unmounted = falsewhen re-didMount-ing.