Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDMO 2.2.0 #878

Merged
merged 556 commits into from
Sep 5, 2024
Merged

RDMO 2.2.0 #878

merged 556 commits into from
Sep 5, 2024

Conversation

jochenklar
Copy link
Member

@jochenklar jochenklar commented Dec 12, 2023

@coveralls
Copy link

coveralls commented Dec 12, 2023

Coverage Status

coverage: 91.454% (-0.1%) from 91.591%
when pulling a84da43 on dev-2.2.0
into 065d195 on main.

@jochenklar
Copy link
Member Author

Rebased to 2.1.1.

@MyPyDavid
Copy link
Member

rebased to 2.1.2 at 2dbdb49

@MyPyDavid
Copy link
Member

MyPyDavid commented Jan 18, 2024

rebased to main at 14f94ed but a test is failing needed to re-run

test:

FAILED rdmo/projects/tests/test_viewset_project_snapshot.py::test_delete[7-1-guest-guest] - assert False

  • where False = <bound method Path.exists of PosixPath('/home/runner/work/rdmo/rdmo/testing/media_root/projects/1/values/238/rdmo-logo.svg')>()
    "config.settings">.MEDIA_ROOT

@MyPyDavid
Copy link
Member

needed to rebase on main because of changes to rdmo/core/templates/core/home_text_en.html

@jochenklar
Copy link
Member Author

jochenklar commented Jun 20, 2024

Force-pushed to remove the double commits. I cherry picked everything from 1bf0d46. The last two merge commits are just cherry picked emtpy. I hope this does not cause trouble later.

@MyPyDavid
Copy link
Member

thanks for the cherry pick 🙏, should we set this PR to "ready for review" so that potential conflicts to main already become visible?

@jochenklar jochenklar marked this pull request as ready for review June 20, 2024 13:06
@jochenklar jochenklar added this to the RDMO 2.2.0 milestone Jul 4, 2024
MyPyDavid and others added 15 commits July 12, 2024 11:39
MyPyDavid and others added 3 commits August 21, 2024 09:41
…updates/setuptools-gte-69-and-lt-74

Update setuptools requirement from <73,>=69 to >=69,<74
Dependency updates August 24 (2.2.0)
@MyPyDavid
Copy link
Member

I found a minor issue with icon colors in the management.
Are these colors because of my faulty css variables or because of some missing css classes in the react components? 🤔
The green is my link-color and the dark is the visited color, but I would expect that all the icons get the same color combination right? So that those blue icons would also be green.
image

@jochenklar
Copy link
Member Author

I will check.

MyPyDavid and others added 5 commits August 21, 2024 14:56
…ncies-to-ranges-with-minimum-and-maximum-versions-for-each-package

build(pyproject): pin all current dependencies to >=min,<max ranges (#1119)
@MyPyDavid
Copy link
Member

I could look at it tomorrow as well, the leftover PRs are ready for review https://github.com/rdmorganiser/rdmo/pulls?q=is%3Aopen+is%3Apr+milestone%3A%22RDMO+2.2.0%22

Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice release with many changes!

Test coverage could be improved afterwards

Coverage decreased (-1.1%) to 90.467%

@jochenklar
Copy link
Member Author

I fixed a tiny race condition in the configureStore for projects.

@jochenklar jochenklar merged commit 7a81000 into main Sep 5, 2024
17 checks passed
@jochenklar jochenklar deleted the dev-2.2.0 branch September 20, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants