Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor progress bar and overview #679

Merged
merged 12 commits into from
Nov 16, 2023
Merged

Conversation

jochenklar
Copy link
Member

@jochenklar jochenklar commented Aug 22, 2023

This PR aims to:

@jochenklar
Copy link
Member Author

Input from @sa-wetter: Numbers should be always show in the progress bar.

Base automatically changed from dev-2.0.0 to master September 21, 2023 15:52
@MyPyDavid MyPyDavid added this to the 2.1.0 milestone Sep 21, 2023
@jochenklar jochenklar marked this pull request as ready for review September 28, 2023 14:32
@coveralls
Copy link

coveralls commented Sep 28, 2023

Coverage Status

coverage: 80.514% (+0.2%) from 80.339% when pulling 4608efe on refactor_progressbar into ee6bd48 on master.

@jochenklar jochenklar changed the base branch from master to dev-2.1.0 October 10, 2023 09:07
@jochenklar jochenklar self-assigned this Oct 10, 2023
Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think it works nicely in the interview!
It has a lot of logic in the progress.py and looks well-tested.
Is the recursivity really necessary? It will be hard to debug or change, but it works now so...
Ive added a small refactor for the ValueQuerySet manager, maybe this can be used in other places as well..

In the project overview, I would rather have the progess as 15/30 instead of 50% but this can be easily changed.

@MyPyDavid
Copy link
Member

Had one more question, it does not update the progress with the Question Autosave or?

@jochenklar
Copy link
Member Author

It does work! Just tested. Can I merge?

Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jochenklar
Copy link
Member Author

I changed the view in the projects table to match the string in the interview.

@jochenklar jochenklar merged commit 0485fe9 into dev-2.1.0 Nov 16, 2023
18 checks passed
@jochenklar jochenklar deleted the refactor_progressbar branch December 12, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants