-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor progress bar and overview #679
Conversation
ffbc4b5
to
9437883
Compare
Input from @sa-wetter: Numbers should be always show in the progress bar. |
9437883
to
337fca2
Compare
4608efe
to
1374e74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think it works nicely in the interview!
It has a lot of logic in the progress.py
and looks well-tested.
Is the recursivity really necessary? It will be hard to debug or change, but it works now so...
Ive added a small refactor for the ValueQuerySet
manager, maybe this can be used in other places as well..
In the project overview, I would rather have the progess as 15/30
instead of 50%
but this can be easily changed.
Had one more question, it does not update the progress with the Question Autosave or? |
It does work! Just tested. Can I merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
I changed the view in the projects table to match the string in the interview. |
when using the API and add progress to the project overview (#488)
6ac5249
to
ade14af
Compare
This PR aims to: