refactor: add pyproject.toml #663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afuetterer
force-pushed
the
add-toml-to-dev-setup-refactoring
branch
from
bb879f1
to
647507b
Compare
|
Whoops, I messed up the dependencies. See #664 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
there is still room for improvement, but I wanted to suggest the toml for further discussion.
I added the following dependency groups:
But tests, dev and ci are pretty similar.
Do you want to enforce using pre-commit for contributors? That is always a good idea. But if you want to use isort, flake8, (maybe black), you need to have on linting/reformatting-PR, I guess with the described 600+ files being changed. Also pre-commit should run on CI.
I can add isort settings, flake8 sadly cannot be configured using the toml file. I would nowadays always recommend using ruff, which is really great and fast and adopted by major projects like pandas. ruff can replace isort and flake8 in my opinion.
Another question is still #648. The installation process using the toml file does not work with Python 3.6.
What do you think?