Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update ci job run conditions #662

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

afuetterer
Copy link
Member

Hi there,

after merging #652, you immediately received a couple or PRs by dependabot, which is great.

Dependabot creates an individual branch per updated dependency it found. With the current CI configuration each PR runs 12 CI jobs, 6 on the branch and 6 on the PR. A bit too much.

Running CI jobs only on master and PRs is also part of #586. But as that PR is still WIP, I wanted to suggest to merge this smaller change as soon as possible, to reduce the number of CI job runs.

What do you think?

@coveralls
Copy link

Coverage Status

coverage: 91.339%. remained the same when pulling 4566e24 on afuetterer:github-actions into ee4d7ff on rdmorganiser:master.

@MyPyDavid
Copy link
Member

MyPyDavid commented Aug 4, 2023

thanks @afuetterer , I agree to make this into a PR and have just one question.

In #586, I wrote for the on: push: condition to include tags and release/**. However, at the moment we don't have any special pipeline for tags or release so this is actually not needed right?

on: 
  push:
    branches: 
      - master
      - 'releases/**'
    tags:
      - '*.*.*'
  pull_request:

@afuetterer
Copy link
Member Author

afuetterer commented Aug 4, 2023

Hi @MyPyDavid, I just wanted to speed things up a bit and a more atomic change to be merged quickly. #586 is important, but also a very big change, that could take longer. The PR was opened in February. 😄

Yes, sure, if you want to include tags and releases to trigger the CI, please include those.

But what you suggest means that a branch's name has to start with "releases". To trigger CI on a release, like you did with tag, is actually:

on: 
  push:
    release:
      types: [published]
...

see: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release

And yes, you could trigger a CI run to push a package to PyPI or build documentation or something.

Feel free to edit my commit.

Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, yes that's what I meant 😉
No, I would keep it with this commit and add other "features" to the pipelines later.

@jochenklar jochenklar merged commit c0ef3b9 into rdmorganiser:master Aug 17, 2023
7 checks passed
@afuetterer afuetterer deleted the github-actions branch August 17, 2023 11:58
CalamityC pushed a commit to CalamityC/rdmo that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants