Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 2.0.0 cleanup #624

Merged
merged 37 commits into from
Jul 27, 2023
Merged

Dev 2.0.0 cleanup #624

merged 37 commits into from
Jul 27, 2023

Conversation

jochenklar
Copy link
Member

  • Remove views, static directories and templates for the old management interfaces
  • Remove copy functions
  • Rename key to uri_path for Condition, Task and View
  • Refactor serializers (and remove list serializers)

interfaces, remove copy functions, and rename key -> uri_path for
Condition, Task and View
@MyPyDavid
Copy link
Member

only these tests are still failing. Do you want to include these in this PR?

rdmo/management/tests/test_import_conditions.py FFFF                     [  4%]
rdmo/management/tests/test_import_domain.py .F.F                         [  4%]
rdmo/management/tests/test_import_options.py .F.F.F                      [  4%]
rdmo/management/tests/test_import_questions.py .F.F.F.F.F.F              [  4%]
rdmo/management/tests/test_import_tasks.py FFFF                          [  4%]
rdmo/management/tests/test_import_views.py FFFF                          [  4%]
rdmo/management/tests/test_viewset_import.py .....F..F.F..F...........   [  4%]
rdmo/management/tests/test_viewset_upload.py .....F..F.F..F.F..F........ [  4%]

@MyPyDavid MyPyDavid added this to the 2.0.0 milestone Jul 13, 2023
@MyPyDavid
Copy link
Member

MyPyDavid commented Jul 13, 2023

For the copying of sites and editors fields, we would like to have them either empty or filled with current site for example.
This code below would make them empty, but would it be possible (not too difficult) to implement the current site feature in this PR?

// management/assets/js/reducers/elementsReducer.js
if (state.elementAction == 'copy') {
    action.elements.element.id = null
    action.elements.element.read_only = false
    action.elements.element.sites = [] // or current site
    action.elements.element.editors = []  // or current site
  }

@jochenklar
Copy link
Member Author

I created a new PR to this PR for this: #640

@jochenklar
Copy link
Member Author

It actually needs to be done in the action not the reducer, since the reducer has no access to the config part of the redux store.

@jochenklar jochenklar merged commit 31d648d into dev-2.0.0 Jul 27, 2023
12 checks passed
@jochenklar jochenklar deleted the dev-2.0.0-cleanup branch July 27, 2023 16:50
@jochenklar jochenklar mentioned this pull request Aug 26, 2023
CalamityC pushed a commit to CalamityC/rdmo that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants