Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rdmo-admin script #1185

Open
wants to merge 2 commits into
base: 2.3.0
Choose a base branch
from
Open

Add rdmo-admin script #1185

wants to merge 2 commits into from

Conversation

jochenklar
Copy link
Member

This PR adds a rdmo-admin script, which works like the django-admin script and offers a way to use management scripts outside an rdmo-app (e.g. in the rdmo repo).

(My) use cases are:

rdmo-admin npm run install
rdmo-admin npm run watch
...

instead of

nvm use
npm run watch
...

or

rdmo-admin build

instead of

python -m build

which might not be to impressive, but has a more uniform interface and might be easier to document.

I think this could really be helpful if we extent it to help with the setup of RDMO, something like

pip install rdmo
rdmo-admin init

We could even think about replacing rdmo-app with a cookiecutter, but I am not sure about this, yet.

Another use case would be to simplify the makemessages step.

Any other ideas are welcome. Also, do we need this or is this additional complexity.

@jochenklar jochenklar self-assigned this Nov 7, 2024
@coveralls
Copy link

coveralls commented Nov 7, 2024

Coverage Status

coverage: 90.409% (-0.07%) from 90.478%
when pulling b46853f on rdmo_admin
into 1eadee5 on main.

@MyPyDavid
Copy link
Member

rdmo-admin startapp ?? 😅

@jochenklar
Copy link
Member Author

Maybe we should combine commands, build could run npm run build:prod and python -m build, while watch just runs npm run watch.

@jochenklar
Copy link
Member Author

After some thoughts I am wondering if this only solves my problems and could be better solved with a local custom script or Makefile. We can discuss this in our next meeting.

@MyPyDavid
Copy link
Member

I would keep it, think it's also useful for the local dev setup..

@jochenklar jochenklar changed the base branch from main to 2.3.0 November 14, 2024 15:14
@jochenklar jochenklar marked this pull request as ready for review November 14, 2024 15:14
@jochenklar jochenklar added this to the RDMO 2.3.0 milestone Nov 14, 2024
@jochenklar
Copy link
Member Author

Rebased and ready (after tests are ok).

def clean_dir(self, path, quiet=False):
if path and os.path.exists(path):
shutil.rmtree(path)
if not quiet:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does quiet come from? it's not in the command arguments

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To not "log" removal of the __pycache__ directories, see L37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants