-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interview contact modal #1157
base: interview-copy-dataset
Are you sure you want to change the base?
Interview contact modal #1157
Conversation
|
||
<p> | ||
{% blocktrans trimmed %} | ||
If you have questions about a question or other inqueries to support, you can use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe:
If you have questions about a question or other inqueries to support, you can use the | |
If you have a question or feedback please get in touch with us, you can use this form to send an email to the {{ request.site.name }} support" | |
or is it meant to be overwritten in the rdmo-app anyway?
@@ -91,3 +91,6 @@ | |||
PROJECT_IMPORTS_LIST = ['url'] | |||
|
|||
PROJECT_VALUES_VALIDATION = True | |||
|
|||
PROJECT_CONTACT = True | |||
PROJECT_CONTACT_RECIPIENTS = ['[email protected]'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice-to-have feature request for this PR would be to have this setting to be editable in the admin UI..
That would open a whole other feature of having settings in the Django Models right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, lets not start this now. we would need a settings or config model and also some good way to cache the entries there. the nice thing about django.conf.settings
is that its super fast.
also: settings by site? 🤯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, yeah settings is nice and fast ;)
of course it would be by site and maybe role-based permissions, etc..
This PR adds the possibility to send questions though a contact form directly from the interview. It contains:
PROJECT_CONTACT
andPROJECT_CONTACT_RECIPIENTS
settingsfetchContact
,sendContact
,closeContact
actions and acontactResolver
for the Redux storeQuestionContact
(the button) andContact
(the modal) componentsResolves: #502
Screenshot: