Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interview contact modal #1157

Draft
wants to merge 4 commits into
base: interview-copy-dataset
Choose a base branch
from

Conversation

jochenklar
Copy link
Member

@jochenklar jochenklar commented Sep 27, 2024

This PR adds the possibility to send questions though a contact form directly from the interview. It contains:

  • PROJECT_CONTACT and PROJECT_CONTACT_RECIPIENTS settings
  • different templates to customize emails and help texts
  • API endpoints to create the message and the subject, which then can be edited by the user, and to send it via email
  • fetchContact, sendContact, closeContact actions and a contactResolver for the Redux store
  • QuestionContact (the button) and Contact (the modal) components

Resolves: #502

Screenshot:

Screen Shot 2024-09-27 at 18 20 35

Screen Shot 2024-09-27 at 18 20 42

@jochenklar jochenklar added this to the RDMO 2.3.0 milestone Sep 27, 2024
@jochenklar jochenklar self-assigned this Sep 27, 2024

<p>
{% blocktrans trimmed %}
If you have questions about a question or other inqueries to support, you can use the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe:

Suggested change
If you have questions about a question or other inqueries to support, you can use the
If you have a question or feedback please get in touch with us, you can use this form to send an email to the {{ request.site.name }} support"

or is it meant to be overwritten in the rdmo-app anyway?

@@ -91,3 +91,6 @@
PROJECT_IMPORTS_LIST = ['url']

PROJECT_VALUES_VALIDATION = True

PROJECT_CONTACT = True
PROJECT_CONTACT_RECIPIENTS = ['[email protected]']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice-to-have feature request for this PR would be to have this setting to be editable in the admin UI..
That would open a whole other feature of having settings in the Django Models right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, lets not start this now. we would need a settings or config model and also some good way to cache the entries there. the nice thing about django.conf.settings is that its super fast.

also: settings by site? 🤯

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, yeah settings is nice and fast ;)
of course it would be by site and maybe role-based permissions, etc..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants