fix(management,merge_attributes): allow target attributes with descendants #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dants Signed-off-by: David Wallace <[email protected]>
MyPyDavid
commented
Aug 20, 2024
| @@ -55,14 +55,15 @@ def handle(self, *args, **options): | |||
| verbosity = options.get('verbosity', 1) | |||
|
|
|||
| source = get_valid_attribute(source, message_name='Source') | |||
| target = get_valid_attribute(target, message_name='Target') | |||
| target = get_valid_attribute(target, message_name='Target', allow_descendants=True) | |||
There was a problem hiding this comment.
this is main part of the change
MyPyDavid
commented
Aug 20, 2024
MyPyDavid
commented
Aug 20, 2024
| @@ -121,16 +124,65 @@ def _create_new_merge_attributes_and_views(db, settings): | |||
| create_copy_of_view_that_uses_new_attribute(db, NEW_MERGE_URI_PREFIXES) | |||
|
|
|||
|
|
|||
| @pytest.mark.usefixtures("_create_new_merge_attributes_and_views") | |||
| def test_command_merge_attributes_fails_correctly(db, settings): | |||
There was a problem hiding this comment.
added some test for when it should fail because the input source or target was wrong
jochenklar
approved these changes
Aug 20, 2024
Signed-off-by: David Wallace <[email protected]>
|
Ive updated the style and tests have passed. This can be merged right? |
|
Go for it. I think I approved before you asked for it. |
|
yes ;) , thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge_attributes, addallow_descendants=Truefor thetargetattributetest_command_merge_attributes_fails_correctlyDescription
Related issue: #990
Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of Changes
Checklist