Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use npm ci instead npm install for build (#1115) #1118

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

MyPyDavid
Copy link
Member

@MyPyDavid MyPyDavid commented Aug 15, 2024

Description

Related issue: #1115
minimal change

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of Changes

  • Build related changes, ci

Checklist

  • All new and existing tests passed.

@MyPyDavid MyPyDavid linked an issue Aug 15, 2024 that may be closed by this pull request
@MyPyDavid
Copy link
Member Author

the build with npm ci fails here,
should I commit a new package-lock.json in here or directly on the dev-2.2.0? @jochenklar
think it makes sense to fix it here first and then merge..

@jochenklar
Copy link
Member

Merge remaining stuff in dev-2.2.0, fix here, merge

@jochenklar
Copy link
Member

Even better: Merge remaining stuff in dev-2.2.0, rebase here, fix here, merge

@MyPyDavid MyPyDavid added this to the RDMO 2.2.0 milestone Aug 15, 2024
@MyPyDavid MyPyDavid self-assigned this Aug 15, 2024
@MyPyDavid MyPyDavid added the dependencies Pull requests that update a dependency file label Aug 21, 2024
@MyPyDavid MyPyDavid marked this pull request as ready for review August 21, 2024 14:52
Copy link
Member

@jochenklar jochenklar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@MyPyDavid MyPyDavid merged commit 1896954 into dev-2.2.0 Aug 21, 2024
18 checks passed
@MyPyDavid MyPyDavid deleted the 1115-use-npm-ci-in-ci branch August 21, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file status:hold type:maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use npm ci in CI
2 participants