Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax dependencies #324

Merged
merged 13 commits into from
Nov 1, 2024
Merged

Relax dependencies #324

merged 13 commits into from
Nov 1, 2024

Conversation

sjperkins
Copy link
Member

@sjperkins sjperkins commented Oct 31, 2024

  • Tests added / passed

    $ py.test -v -s africanus

    If the pre-commit tests fail, install and
    run the pre-commit hooks in your development
    virtuale environment:

    $ pip install pre-commit
    $ pre-commit install
    $ pre-commit run -a
  • Fully documented, including HISTORY.rst for all changes
    and one of the docs/*-api.rst files for new API

    To build the docs locally:

    pip install -r requirements.readthedocs.txt
    cd docs
    READTHEDOCS=True make html

📚 Documentation preview 📚: https://codex-africanus--324.org.readthedocs.build/en/324/

@sjperkins
Copy link
Member Author

In #322, most codex dependencies were upgraded to fairly recent versions.

This PR relaxes the dask and numpy requirements somewhat, but numba remains at 0.60, mostly because there's a numpy >= 2 dependency.

Pinging @landmanbester @JSKenyon for review here as these upgrades might be aggressive for Quartical and pfb-imaging.

Copy link
Collaborator

@landmanbester landmanbester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my side, happy with the upgrades

Copy link
Collaborator

@JSKenyon JSKenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QuartiCal has bracketed dependencies so this won't break it. I will do a QuartiCal release at some point to update to this version and iron out any bugs (but the tests already pass).

@sjperkins
Copy link
Member Author

Thanks for taking a look

@sjperkins sjperkins merged commit 0009571 into master Nov 1, 2024
1 check passed
@sjperkins sjperkins deleted the relax-dependencies branch November 1, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants