Add the UltmtCdtr block for SEPA Direct Debit (Ultimate Creditor) + Customizable MsgId and InitgPty node #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nickinthebox
changed the title
…value is true, would need `AmdmntInfDtls` node with its child nodes)
Nickinthebox
changed the title
|
Nice, thanks! Would you be able to add a test to the test suite as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional Ultimate Creditor block for SEPA Direct Debit.
I have implemented it for Organization only (not individuals) following ISO 20022 (french source)
Allow customizable
msg_id(MsgIdnode) option.Allow customizable
initiating_partyandinitiating_party_id(InitgPtynode) options instead of mandatory copyingname&creditor_idin this node.Limit manually set
endtoend_idoption to 35 chars to meet SEPA standards requirements.Also add a default
AmdmntIndnode set tofalseas it can be required by some banks (if we set it to true, we would need to provide extra details about what has changed in an extraAmdmntInfDtlsnode, which is not as easy as it seems as it needs multiple child nodes)