Experimental -> Main #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The Eye turns on when you have picked up item on morph pedestal, not when you have Morphing Ball.
Side Effects are clearly being caused through changes to memory. There's no easy way to resolve this.
Fixed a graphics bug that caused map graphics in the hex map to bug out when starting a new game that had a beam as a starting item.
Miepee
reviewed
Sep 27, 2023
Comment on lines
+141
to
+142
| src/test_rom_patcher.py | ||
| src/test_data.json |
There was a problem hiding this comment.
Why are these in the gitignore? tests sound like they should be tracked.
There was a problem hiding this comment.
These are just super lightweight things I use for quickly prototyping things. The py is like a one-liner so I don't forget how to run the program, and I don't use it rn. The test_data is completely incidental and I constantly replace and rewrite it during testing.
There was a problem hiding this comment.
Cant you put them in a local git ignore instead then?
There was a problem hiding this comment.
There was a problem hiding this comment.
Will remove. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.