Security issue with snapshot integrity verification #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes checksum calculation in GetEtcdSnapshotChecksum from md5sum to sha256sum to provide stronger cryptographic verification of etcd snapshots. SHA-256 is cryptographically more secure and resistant to collision attacks compared to MD5. Note: This changes the checksum length from 32 to 64 characters. The command execution and output parsing remain unchanged as both commands use the same output format. Technical details: - Changed command from md5sum to sha256sum in shell execution - Output format remains "<hash> <filename>" - Post-processing with cut and tr commands unaffected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3669
MD5 is not secure for file integrity verification: https://docs.datadoghq.com/code_analysis/static_analysis_rules/go-security/import-md5/
Changes:
Replaced
md5sumwithsha256sumfor calculating snapshot checksums