Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image variable includes full image path already #1989

Merged

Conversation

davidcassany
Copy link
Contributor

Fixes a regression in grub.cfg, the image variable is already passed as a full image path from grub.

@davidcassany davidcassany requested a review from a team as a code owner March 5, 2024 12:45
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.54%. Comparing base (b424822) to head (fafe005).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1989   +/-   ##
=======================================
  Coverage   72.54%   72.54%           
=======================================
  Files          76       76           
  Lines        8896     8896           
=======================================
  Hits         6454     6454           
  Misses       1909     1909           
  Partials      533      533           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@anmazzotti anmazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a try and this fixes the issue I was seeing with passive grub entry being unusable.

@davidcassany davidcassany merged commit a7fec29 into rancher:main Mar 5, 2024
17 of 19 checks passed
@davidcassany davidcassany deleted the fix_fallback_image_reference branch March 5, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants