Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay on the snapshotter setup of the installed system for upgrades #1979

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany requested a review from a team as a code owner February 26, 2024 16:55
Copy link
Contributor

@anmazzotti anmazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: David Cassany <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 72.97%. Comparing base (ab63f56) to head (e03fdfb).

Files Patch % Lines
pkg/action/upgrade.go 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1979   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files          74       74           
  Lines        8722     8722           
=======================================
  Hits         6365     6365           
  Misses       1838     1838           
  Partials      519      519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidcassany davidcassany merged commit 2b593b3 into rancher:main Feb 27, 2024
17 of 19 checks passed
@davidcassany davidcassany deleted the fix_upgrade_default_setup branch February 27, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed upgrade tests in UI
3 participants