-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for RISC-V 64bit architecture #1856
Conversation
85ba58e
to
5f44860
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1856 +/- ##
==========================================
- Coverage 75.29% 75.09% -0.21%
==========================================
Files 67 67
Lines 6825 6869 +44
==========================================
+ Hits 5139 5158 +19
- Misses 1315 1340 +25
Partials 371 371 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
dab8bc8
to
8f68137
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work, psyched to see riscv support!
That said, this PR breaks current multi-platform workflow. I would like to be able to write make PLATFORM=linux/amd64,linux/arm64,linux/riscv64 build
and get a multi-platform image that can be pushed and has all dependencies needed to build other systems.
Here the grub entry with the latest fixes, no more hardcoded
|
499f795
to
dcaac6d
Compare
dcaac6d
to
bedaa31
Compare
It should be doable, but keep in mind that qemu docker configuration will be needed to be able to build the full OS stack (or native client on docker). But the CLI can be compiled for all supported arch directly (thanks to cross-compiling) from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Cool too see riscv
I think this PR should be merged before #1858
dff41ec
to
adb9464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! 👍
Basic support of riscv64 architecture. Shim is not supported yet, will be added later. Signed-off-by: Loic Devulder <[email protected]>
As only 64 architectures are supported Signed-off-by: Loic Devulder <[email protected]>
adb9464
to
34d2031
Compare
Basic support of riscv64 architecture.
TODO:
More work needed, but not something that should block this PR, will be done whenshim
is not supported yet, package is not available in Tumbleweed but could be compiled.shim
will be available in openSUSE.x86_64
path for GRUB loader directory.Maybe find an elegant way to add DTB in EFI partition (Followed in Find a way to add DTB in EFI partition (for ARM and RISC-V) #1861./EFI/dtb/
for SUSE based distributions), could be useful for arm64 too.