-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.9] Use BundleDeployment status to calculate GitRepo resources #12443
base: release-2.9
Are you sure you want to change the base?
[2.9] Use BundleDeployment status to calculate GitRepo resources #12443
Conversation
ff3a824
to
8636de0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a first glance.
Not sure if applicable unit tests exist?
Also: linter failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't done much functional testing. once we work through some of the code review items will crack on
5dec55e
to
93b259e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking into the bug that fails to show the correct resource state (reopened comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Just blocked on branch opening up to 2.9.5 changes (and e2e tests passing)
Summary
Fixes #12517
Occurred changes and/or fixed issues
GitRepo details include a tab for
Resources
, which iterates over the list ofstatus.resources
in theGitRepo
object. However, this is inaccurate, since the source of truth for resources areBundleDeployments
, as they may vary depending on the target cluster customization.Technical notes summary
find
to pick just the first bundle deployment matching the cluster label, which is totally wrong. Now we iterate directly on bundle deployments instead, then pick the target cluster as necessary.Bundles
payload is thespec.resources
, as it basically contains all the raw chart contents. I've modified the getter to make steve omit that field.Areas or cases that should be tested
Areas which could experience regressions
This PR actually aims to provide the same output while changing how the information is computed.
Screenshot/Video
Checklist