-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implement basic support for distributed signatures #39
base: master
Are you sure you want to change the base?
Conversation
In order to perform this kind of request, we need the order id and its order type.
what is missing here? can we merge this one? |
ping @namxam what's the status here? |
bump bumper bumpest |
super(client) | ||
self.document = document | ||
self.key ||= cipher.random_key | ||
end | ||
|
||
def segmented? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you choose segmented
as name? Kinda reminds me of segmented downloads
|
||
# Fetch overview of all orders which need to be signed | ||
def HVU | ||
Epics::H004.from_xml(download(Epics::HVU)).to_h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really need this intermediate class Epics::H004
which determines the type and reacts accordingly? I mean in this method we already know that the result will be HVU
anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could refactor it to something like:
def download(klass)
res = ... do all the things
klass.response.new(res)
end
class Klass
def headers
....
end
def response
KlassRresponse
end
end
class KlassResponse
def initialize(res)
// do whatever
end
def to_h
end
end
moar bumping |
Lars Brillert seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This pull request adds support for a few basic VEU order types. Those include:
The implementation is not yet feature complete, but should include those basic features which should cover most use cases.