Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement basic support for distributed signatures #39

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

namxam
Copy link
Contributor

@namxam namxam commented Mar 31, 2016

This pull request adds support for a few basic VEU order types. Those include:

  • HVU to fetch a generic overview of all orders
  • HVZ to fetch a detailed overview of all orders
  • HVT to fetch details for an order (most notably the display file)
  • HVE to sign an order
  • HVS to reject an order

The implementation is not yet feature complete, but should include those basic features which should cover most use cases.

@bumi
Copy link
Collaborator

bumi commented Jun 9, 2017

what is missing here? can we merge this one?

@bumi
Copy link
Collaborator

bumi commented Jun 18, 2017

ping @namxam what's the status here?

@bumi
Copy link
Collaborator

bumi commented Jul 28, 2017

bump bumper bumpest
🍹

super(client)
self.document = document
self.key ||= cipher.random_key
end

def segmented?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you choose segmented as name? Kinda reminds me of segmented downloads


# Fetch overview of all orders which need to be signed
def HVU
Epics::H004.from_xml(download(Epics::HVU)).to_h
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need this intermediate class Epics::H004 which determines the type and reacts accordingly? I mean in this method we already know that the result will be HVU anyways.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could refactor it to something like:

def download(klass) 
  res = ... do all the things
  klass.response.new(res)
end

class Klass
  def headers
   ....
   end

  def response
    KlassRresponse
  end
end
class KlassResponse
  def initialize(res)
   // do whatever
  end
  def to_h
  end 
end

@bumi
Copy link
Collaborator

bumi commented Sep 7, 2017

moar bumping

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Lars Brillert
❌ namxam


Lars Brillert seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants