Fix GetWindowDpiAwarenessContext NULL check #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Nov 7, 2024
Co-authored-by: Andrew Murray <[email protected]>
radarhere
reviewed
Nov 7, 2024
Comment on lines
+363
to
+366
| GetWindowDpiAwarenessContext_function = (Func_GetWindowDpiAwarenessContext | ||
| )GetProcAddress(user32, "GetWindowDpiAwarenessContext"); | ||
| if (screens == -1 && GetWindowDpiAwarenessContext_function != NULL) { | ||
| dpiAwareness = GetWindowDpiAwarenessContext_function(wnd); |
There was a problem hiding this comment.
Suggested change
| GetWindowDpiAwarenessContext_function = (Func_GetWindowDpiAwarenessContext | |
| )GetProcAddress(user32, "GetWindowDpiAwarenessContext"); | |
| if (screens == -1 && GetWindowDpiAwarenessContext_function != NULL) { | |
| dpiAwareness = GetWindowDpiAwarenessContext_function(wnd); | |
| if (screens == -1) { | |
| GetWindowDpiAwarenessContext_function = (Func_GetWindowDpiAwarenessContext | |
| )GetProcAddress(user32, "GetWindowDpiAwarenessContext"); | |
| if (GetWindowDpiAwarenessContext_function != NULL) { | |
| dpiAwareness = GetWindowDpiAwarenessContext_function(wnd); | |
| } |
So your feeling is that your current version is simpler than this suggestion? I think your version is also probably fine.
There was a problem hiding this comment.
I generally find fewer nested if statements to be easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for my suggestion for #8456
I also slightly simplified the code and removed the use of the
DPI_AWARENESS_CONTEXTtype - IIRC it was not available in VS2017.