-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set sender/receiver capabilities to attach frame in the amqp10_client #11337
base: main
Are you sure you want to change the base?
Conversation
26fedc1
to
a24e3f6
Compare
9b524cd
to
52cd6be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that we first test end-to-end that the RabbitMQ <-> IBM MQ integration works before merging this PR.
Right now, this PR adds a lot of boilerplate code that is not used and contains bugs.
d8f7a42
to
dd3e169
Compare
182a482
to
2563327
Compare
0c1536a
to
db6ef7b
Compare
db6ef7b
to
b98e7e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get sometimes the following error
system_SUITE > ibmmq > basic_roundtrip_ibmmq
#1. {error,
{shutdown,
{gen_statem,call,
[<0.540.0>,
{attach,
#{name => <<"banana-sender">>,filter => #{},
properties => #{},rcv_settle_mode => first,
role =>
{sender,
#{address => <<"DEV.QUEUE.3">>,
capabilities => <<"queue">>,
durable => unsettled_state}},
snd_settle_mode => settled}},
5000]}}}
when running
make -C deps/amqp10_client/ ct-system
locally on Ubuntu.
Might be worth checking this flake?
e110ecb
to
70839ed
Compare
To help troublehshoot an issue originated from translate_terminus_capabilities
added capture_logs function to the ibmmq_helper but not called until I figure out how to add extra logging. So far the only auth events captured are those originated from the admin ui
8b7e856
to
0a4d8a8
Compare
Proposed Changes
It partially addresses the feature request #10752. This PR lets a developer set the capabilities to the sender and receiver links in the amqp10_client. It will not add this capability to the shovel plugin though.
The system test group
ibmmq
requires a docker image for IBM MQ server. This docker image is built by a workflow added by this other PR #11419. The official IBM MQ docker image does not come with AMQP built-in capability hence we have to build one. And given the amount of time it takes to build this image it was better to build it from its own CI workflow.NOTE for reviewer:
ibmmq
, it pulls a docker image based on amd64 arch. It does not take into account the local arch because the other possible architecture is arm64 and it is not possible to build a docker image for ARM64 with AMQP capabilities. (see https://github.com/rabbitmq/rabbitmq-server/blob/set-amqp10-capabilities/deps/amqp10_client/test/system_SUITE_data/ibmmq_runner#L11 for more context)Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that apply