chore(ci): Remove workaround for broken cc version
#2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheus23
force-pushed
the
matheus23/update-cc
branch
from
dbba182
to
5d4a735
Compare
djc
approved these changes
Nov 15, 2024
|
Honestly, I'm not sure. I've only seen these tests break in github actions so far. Locally, running the cargo tests for wasm32-unknown-unknown with cc version 1.1.32-37 was just fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've previously had this workaround in CI for
ccversions between version1.1.32and1.1.37which broke theringbuild for wasm32-unknown-unknown in github actions.Version
1.2.0is now released and doesn't breakringanymore.Related PRs: