feat: QUIC Address discovery extension #2043
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add frame types transport parameter encoding and decoding - to my best understanding fix typo add some utility functions add initial observed address frames add frame encoding and decoding adjust stats minimal debugging for received observed addr simplify setting extension in transport parameter rework frame structure and send observed addr frames with path challenge ones tweak example to start testing fix encoding, send with handshake clippy fix docs reject observed addr frames when not negotiated replace request_id with seq_no according to new spec replace code point for transport parameter replace code point for frames remove sending observed address frame in handshake in server side treat as probing frame in payload processing ack is already managed by is_ack_eliciting send with path_response as well add frame to retransmits and ignore old frames send observed addr at least once per path fmt reword comment remove trailing whites keep observed address reports per path remove addressed TODO small improvement in readability add retransmission with fresh info retransmit just once fix should send logic add observed addr event surface the info restore trace level of frames some extra logs rename roles and var improve error msg assuming the default as disabled is ok, remove comment use safe arithmetic with varints for the seq_no move transport param code to method instead of From impl fix example, finally remove excesive log add helper fn carry old report into new path generate notification only on changed values downgrade log add sending test add resumption test on the acceptance case add resumption test on the rejection case spelling actual spelling and undo debug change dumb lints some spelling and formatting add retransmission test make a bit more readable update hexas make naming consistent, add test check docs for consistency
divagant-martian
force-pushed
the
quic-address-discovery
branch
from
276c164
to
b0f0a30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://datatracker.ietf.org/doc/draft-seemann-quic-address-discovery/
Description TBD