Skip to content

Commit

Permalink
Remove "max_tlps" configuration variable
Browse files Browse the repository at this point in the history
It is not used since
<#134>
(commit bdc9ac7)
was merged in 2018.

RFC 9002 also does not mention Tail Loss Probe
except that it has been integrated into the PTO (Probe Timeout)
mechanism.
  • Loading branch information
link2xt authored and Ralith committed Dec 1, 2023
1 parent d1bb2b8 commit b5d23a8
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions quinn-proto/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ pub struct TransportConfig {
pub(crate) receive_window: VarInt,
pub(crate) send_window: u64,

pub(crate) max_tlps: u32,
pub(crate) packet_threshold: u32,
pub(crate) time_threshold: f32,
pub(crate) initial_rtt: Duration,
Expand Down Expand Up @@ -135,12 +134,6 @@ impl TransportConfig {
self
}

/// Maximum number of tail loss probes before an RTO fires.
pub fn max_tlps(&mut self, value: u32) -> &mut Self {
self.max_tlps = value;
self
}

/// Maximum reordering in packet number space before FACK style loss detection considers a
/// packet lost. Should not be less than 3, per RFC5681.
pub fn packet_threshold(&mut self, value: u32) -> &mut Self {
Expand Down Expand Up @@ -331,7 +324,6 @@ impl Default for TransportConfig {
receive_window: VarInt::MAX,
send_window: (8 * STREAM_RWND).into(),

max_tlps: 2,
packet_threshold: 3,
time_threshold: 9.0 / 8.0,
initial_rtt: Duration::from_millis(333), // per spec, intentionally distinct from EXPECTED_RTT
Expand Down Expand Up @@ -365,7 +357,6 @@ impl fmt::Debug for TransportConfig {
stream_receive_window,
receive_window,
send_window,
max_tlps,
packet_threshold,
time_threshold,
initial_rtt,
Expand All @@ -391,7 +382,6 @@ impl fmt::Debug for TransportConfig {
.field("stream_receive_window", stream_receive_window)
.field("receive_window", receive_window)
.field("send_window", send_window)
.field("max_tlps", max_tlps)
.field("packet_threshold", packet_threshold)
.field("time_threshold", time_threshold)
.field("initial_rtt", initial_rtt)
Expand Down

0 comments on commit b5d23a8

Please sign in to comment.