Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow que to be started and create pid file #404

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

jokius
Copy link
Contributor

@jokius jokius commented Oct 12, 2023

It's help when you need make heals check in kubernetes

@oeoeaio
Copy link
Contributor

oeoeaio commented Oct 16, 2023

Thanks for the PR. Are these tests passing for you locally @jokius?

spec/que/locker_spec.rb Outdated Show resolved Hide resolved
@jokius
Copy link
Contributor Author

jokius commented Oct 18, 2023

@oeoeaio Now all tests are green.

Copy link
Member

@ZimbiX ZimbiX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements =)

lib/que/locker.rb Outdated Show resolved Hide resolved
spec/que/locker_spec.rb Outdated Show resolved Hide resolved
lib/que/locker.rb Outdated Show resolved Hide resolved
spec/que/locker_spec.rb Outdated Show resolved Hide resolved
Copy link
Member

@ZimbiX ZimbiX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Cheers!

@ZimbiX ZimbiX merged commit e9715e5 into que-rb:master Oct 19, 2023
21 checks passed
@dkoprov
Copy link

dkoprov commented Aug 19, 2024

Hey! Any plans to release this patch into a new release? 2.4.0 maybe? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants