Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specificity of Rails versions in spec gemfiles #402

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

ZimbiX
Copy link
Member

@ZimbiX ZimbiX commented Oct 9, 2023

The Gemfile that's supposed to test Rails 7.0 was running Rails 7.1 🤦

Issue discovered via Que's Rails 7.0 tests running for #401 saying:

Installing activejob 7.1.0

The Gemfile that's supposed to test Rails 7.0 was running Rails 7.1 🤦

```
Installing activejob 7.1.0
```

https://github.com/que-rb/que/actions/runs/6456183723/job/17525155590?pr=401#step:5:87
@ZimbiX
Copy link
Member Author

ZimbiX commented Oct 9, 2023

Looks like this is working properly now.

Rails 6.0 tests say:

Installing activejob 6.0.6.1

Rails 7.0 tests say:

Fetching activejob 7.0.8

@ZimbiX ZimbiX merged commit 4e08e84 into master Oct 9, 2023
34 checks passed
@ZimbiX ZimbiX deleted the fix-specificity-of-rails-versions-in-spec-gemfiles branch October 9, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant