Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows 16bit compatibility file api #885

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

crass
Copy link
Contributor

@crass crass commented Aug 16, 2021

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out. (What does this mean?)

Extra tests?

  • No extra tests are needed for this PR. (I don't believe there is testing of the winapi)
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR. (unsure if its necessary)

Target branch?

  • The target branch is dev branch.

One last thing


This PR adds the windows 16bit compatibility file api..

@crass crass changed the base branch from master to dev August 16, 2021 03:46
@xwings
Copy link
Member

xwings commented Aug 16, 2021

wow, this is amazing.

will take a serious look and will comment accordingly.

thanks!

@xwings
Copy link
Member

xwings commented Aug 16, 2021

First comment,

will you be able to add a the following

  1. binary
  2. src
  3. make a test case for it, it can be in test_pe.py

@crass
Copy link
Contributor Author

crass commented Aug 16, 2021

will you be able to add a the following

1. binary

This binary is 38Mb. I could probably truncate it to ~5Mb and have it be usable. I would add it to the rootfs repo?

2. src

Is this the source of the binary mentioned in 1? If so, I do not have the source. I also don't know the terms of redistribution, if that matters.

3. make a test case for it, it can be in test_pe.py

Adding a test case looks doable. Assuming nothing above is a deal breaker.

@xwings
Copy link
Member

xwings commented Aug 16, 2021

You are right. I am not sure are those dlls are ok to expose. but we still need a method to test

@crass
Copy link
Contributor Author

crass commented Aug 16, 2021

I'm not a windows dev, nor have a windows dev environment setup. So creating such a binary, while not super hard to write a C file for, would be a pain for me to turn into an executable.

@xwings
Copy link
Member

xwings commented Aug 21, 2021

yup. i will note this in issue #333

@xwings xwings merged commit 35db51a into qilingframework:dev Aug 21, 2021
@xwings xwings mentioned this pull request Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants