Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/boa constrictor 273 close web driver #274

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

pl-shernandez
Copy link
Contributor

@pl-shernandez pl-shernandez commented Jun 10, 2024

Description

Adding a task to close the current window or tab using the WebDriver .Close() function

This functionality enables a solution for an issue some are experiencing with Chrome 124+ and ChromeDriver where orphan windows are not closed with Quit(). #273 but has general utility

This issue is a nightmare for running tests in parallel and affecting our workflow!

Testing

The time sequence in the Windows Task Manager demonstrates two Chrome Browser windows running, one closing and finally the WebDriver quitting. My window for this pull request ^_^ is Google Chrome (8) my test's window is Google Chrome (7). When the Close() command is called Google Chrome (7) terminates. When the Quit() command is called the Chromedriver (32 bit) terminates.
Screenshot 2024-06-10 at 1 57 03 PM
Screenshot 2024-06-10 at 1 57 51 PM
Screenshot 2024-06-10 at 1 58 33 PM

Unit Tests

image

Checklist

  • [x ] I agree to follow Boa Constrictor's Code of Conduct.
  • [ x] I read Boa Constrictor's Contributing Code guide.
  • [ x] I successfully built the .NET solution with no errors or new warnings.
  • [ x] I successfully ran both the unit tests and the example tests.
  • [ x] I updated the appropriate changelogs with concise descriptions of these changes.
  • [ x] I added documentation for these changes (if appropriate).

@pl-shernandez pl-shernandez added the enhancement New feature or request label Jun 10, 2024
Copy link
Contributor

@Swatkins18 Swatkins18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for boy-scouting 😃

@pl-shernandez pl-shernandez merged commit c47c8e7 into main Jun 11, 2024
3 checks passed
@pl-shernandez pl-shernandez deleted the enhancement/BoaConstrictor-273_CloseWebDriver branch June 11, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants