replace _init_optim_state w/ tnt's util #802
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D56446353
Differential Revision: D56446382
Summary: The `_init_optim_state()` util from DCP is identical to the implementation in TorchTNT. However, since the DCP is only in pytorch >=2.3 / nightlies, it won't be compatible with pytorch stable users This diff swaps the implementations. Reviewed By: galrotem Differential Revision: D56446429
JKSenthil
force-pushed
the
export-D56446429
branch
from
4ca7a4c
to
d9cbacb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
_init_optim_state()util from DCP is identical to the implementation in TorchTNT. However, since the DCP is only in pytorch >=2.3 / nightlies, it won't be compatible with pytorch stable usersThis diff swaps the implementations.
Differential Revision: D56446429