Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rank correlation metrics #3276

Merged
merged 7 commits into from
Sep 3, 2024
Merged

Conversation

kzkadc
Copy link
Contributor

@kzkadc kzkadc commented Sep 1, 2024

Description: added Spearman and Kendall rank correlation coefficient metrics.

https://en.wikipedia.org/wiki/Spearman%27s_rank_correlation_coefficient
https://en.wikipedia.org/wiki/Kendall_rank_correlation_coefficient

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added docs module: metrics Metrics module labels Sep 1, 2024
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @kzkadc , I left few comments now about how to handle the imports of scipy in the code. I'll check the tests and docs a bit later, but overall implementation looks ok to me.

ignite/metrics/regression/kendall_correlation.py Outdated Show resolved Hide resolved
ignite/metrics/regression/spearman_correlation.py Outdated Show resolved Hide resolved
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Sep 1, 2024

Please also check code formatting, unit tests CI is also failed due to too long line

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR @kzkadc !

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Sep 3, 2024

CI failures are unrelated, submitted a temporary fix with mlflow version constraints. Once #3278 is merged let's update this PR, rerun the CI and merge if all is green.

@vfdev-5 vfdev-5 enabled auto-merge (squash) September 3, 2024 19:32
@vfdev-5 vfdev-5 merged commit e2f9ac0 into pytorch:master Sep 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants