-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-126699: allow AsyncIterator to be used as a base for Protocols #126702
Conversation
Misc/NEWS.d/next/Library/2024-11-11-13-24-22.gh-issue-126699.ONGbMd.rst
Outdated
Show resolved
Hide resolved
…NGbMd.rst Co-authored-by: Jelle Zijlstra <[email protected]>
Backport? To me this feels like a bug; I don't think it should ever have been removed from the allowlist |
Thanks @tungol for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Thanks @tungol for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Thanks @ZeroIntensity. For the future: I was hoping to give the other people on this PR thread a chance to object before adding the backport labels, or I would have done so myself. It's only 7:20am where Jelle is right now :-) |
Good to know :) As a side note, is the bot sick? Those backport are taking a while. |
I think she may be feeling poorly today, yeah -- there's some discussion on Discord about it |
Thanks @tungol for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Thanks @tungol for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…ls (pythonGH-126702) (cherry picked from commit feb3e0b) Co-authored-by: Stephen Morton <[email protected]>
GH-126761 is a backport of this pull request to the 3.12 branch. |
…ls (pythonGH-126702) (cherry picked from commit feb3e0b) Co-authored-by: Stephen Morton <[email protected]>
GH-126762 is a backport of this pull request to the 3.13 branch. |
AsyncIterator was removed from
_PROTO_ALLOWLIST
by #15647, without any discussion. It looks like an accident to me. This restores it to the list.