Py 3.13 rc #217
Merged
Py 3.13 rc #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means when building multiple python versions this repo is only cloned once
This ensures only packages that have wheels for 3.13 are installed into the 3.13 eval container
When using nargs='?' the nsjail_args argument was sometimes consuming 1 of the arguments passed to the module. By setting these two arguments to store_const actions instead, this is no longer the case, as they will always use the constant specified now. This is more appropriate for their actual use case of being purely for documentation. Co-authored-by: GDWR <[email protected]>
ChrisLovering
force-pushed
the
py-3.13-rc
branch
2 times, most recently
from
7d5ebf2
to
a7c52bf
Compare
This was a breaking change github introduced recently Co-authored-by: GDWR <[email protected]>
ChrisLovering
force-pushed
the
py-3.13-rc
branch
from
a7c52bf
to
b276a04
Compare
MarkKoz
reviewed
Oct 3, 2024
| @@ -29,12 +29,16 @@ RUN apt-get -y update \ | |||
| tk-dev \ | |||
| && rm -rf /var/lib/apt/lists/* | |||
|
|
|||
| RUN git clone -b v2.4.14 --depth 1 https://github.com/pyenv/pyenv.git $PYENV_ROOT | |||
| @@ -13,10 +13,16 @@ def parse_args() -> argparse.Namespace: | |||
| ) | |||
| parser.add_argument("code", help="the Python code to evaluate") | |||
| parser.add_argument( | |||
| "nsjail_args", nargs="?", default=[], help="override configured NsJail options" | |||
| "nsjail_args", | |||
There was a problem hiding this comment.
Do you have a sample of what the help output is after this change?
There was a problem hiding this comment.
Yea, the reason I added the default to the help kwarg directly is because it didn't get added automatically.
❯ python3 -m snekbox --help
usage: snekbox [-h] code [nsjail_args ...] [--- py_args ...]
positional arguments:
code the Python code to evaluate
nsjail_args override configured NsJail options (default: [])
py_args arguments to pass to the Python process (default: ['-c'])
options:
-h, --help show this help message and exit
There was a problem hiding this comment.
Thanks - that still looks helpful
MarkKoz
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Python 3.13 to snekbox.
Actually calling this isn't possible until #196 is merged, which I will be looking into now.