Update to Debian Bookworm #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mount /dev/shm in the container by setting ipc to "private". This is the same as "none" (the previous value) with the only difference being that shm is mounted. This is needed for integration tests to pass. The integration tests always relied on shared memory due to their use of multiprocessing. They managed to work because glibc used to fall back to /tmp if /dev/shm wasn't available. However, newer versions of glibc, which Debian Bookworm now uses, removed that fallback behaviour.
MarkKoz
added
the
area: dependencies
ChrisLovering
requested changes
Sep 16, 2023
There was a problem hiding this comment.
Runs fine. Tested with it integrated tot he bot, works fine too. However ruining the tests locally, I get this failure.
FAIL: test_file_parsing_timeout (tests.test_nsjail.NsJailTests.test_file_parsing_timeout)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/snekbox/tests/test_nsjail.py", line 247, in test_file_parsing_timeout
self.assertEqual(result.returncode, None)
AssertionError: 0 != None
Edit: I dound the issue after some further digging.
The test above is failing due to a race condition. There's a race between the timeout and the max file size. If your PC is fast enough, you'll parse the number of files needed to hit the max file size limit before the timeout of 1s is hit, so the test fails.
The only way I've found to make this pass on my PC is to double memfs_instance_size on that test.
This will be helpful in testing, since some machines are able to process quite a lot in one second, which was the previous lowest timeout.
Updating to Bookworm may have increased performance of the file processing. In any case, this test started failing intermittently on when running on a local machine. Lower the timeout so even fast machines will hit the timeout.
ChrisLovering
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mount /dev/shm in the container by setting ipc to "private". This is the same as "none" (the previous value) with the only difference being that shm is mounted. This is needed for integration tests to pass.
The integration tests always relied on shared memory due to their use of multiprocessing. They managed to work because glibc used to fall back to /tmp if /dev/shm wasn't available. However, newer versions of glibc, which Debian Bookworm now uses, removed that fallback behaviour.