Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: another example of using #427

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Conversation

Truenya
Copy link

@Truenya Truenya commented Jul 11, 2024

just yet another example(found on stackoverflow)

examples/caldav-get-lib.py Outdated Show resolved Hide resolved
Copy link
Member

@tobixen tobixen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icalendar library is not so external, the caldav library already has support for it. Anyway, fix those issues and I'll include this example.

examples/caldav-get-lib.py Outdated Show resolved Hide resolved
examples/caldav-get-lib.py Outdated Show resolved Hide resolved
@tobixen
Copy link
Member

tobixen commented Jul 12, 2024

Also, style test breaks due to the pesky requirements that lines should not exceed 78 characters (I personally hate this limit, but still I believe the python-caldav library should follow the PEP and the "industry standard"). This can be fixed easily by running tox -e style and commit.

@Truenya Truenya changed the title feat: example of using with external library feat: another example of using Jul 12, 2024
@tobixen
Copy link
Member

tobixen commented Jul 12, 2024

Style check is still failing

@Truenya
Copy link
Author

Truenya commented Jul 13, 2024

@tobixen fixed

@tobixen tobixen merged commit b5803ff into python-caldav:master Jul 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants