Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Makefile for development #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ENH: Makefile for development #92

wants to merge 1 commit into from

Conversation

sjsrey
Copy link
Member

@sjsrey sjsrey commented Mar 28, 2020

The current README instructions has the docker container not returning a shell for entry but rather the lab is running. It isn't clear how to move onto the build steps from that point.

The Makefile here is intended to support either running the lab in the container w/o a shell, or getting as shell.

@sjsrey sjsrey requested a review from darribas March 28, 2020 18:40
@sjsrey sjsrey added the enhancement something necessary to improve the quality of instruction. label Mar 28, 2020
@darribas
Copy link
Member

Hey! Thanks for this. My approach has been to launch JupyterLab on a container and then run all the commands to build the website, etc. from inside JupyterLab (on a terminal window, which is equivalent to launching the container with start.sh, but lets you also edit files and try notebooks out). My thinking in that is that if someone is not using a container but has all the dependencies installed locally, they should be able to replicate it too and it doesn't lock them on using Docker.

But it is true that this could be better documented, would it make sense to try to expand on this a bit in the README.md?

docker run -it --rm -p 8888:8888 -p 4000:4000 -v ${PWD}:/home/jovyan/work darribas/gds_dev:4.0

term:
docker run -it --rm -p 8888:8888 -p 4000:4000 -v ${PWD}:/home/jovyan/work darribas/gds_dev:4.0 sh -c "/bin/bash"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the official Jupyter stacks have a convenience script that drops you into a terminal by calling start.sh:

docker run -it --rm  -p 8888:8888 -p 4000:4000 -v ${PWD}:/home/jovyan/work darribas/gds_dev:4.0 start.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement something necessary to improve the quality of instruction.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants