Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPAT: h3 v4 compatibility #768

Merged
merged 1 commit into from
Nov 15, 2024
Merged

COMPAT: h3 v4 compatibility #768

merged 1 commit into from
Nov 15, 2024

Conversation

martinfleis
Copy link
Member

Requires pysal/tobler#218 to work, so likely only dev and oldest will pass until Tobler gets a patch release.

@knaaptime
Copy link
Member

i can get the tobler release out today. Was gonna see if I can fix that issue with the docs along the way but can just do the patch if not

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.3%. Comparing base (4b9970d) to head (e8c0da0).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
libpysal/graph/_indices.py 46.7% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #768     +/-   ##
=======================================
- Coverage   85.4%   85.3%   -0.1%     
=======================================
  Files        150     150             
  Lines      15989   15998      +9     
=======================================
- Hits       13655   13651      -4     
- Misses      2334    2347     +13     
Files with missing lines Coverage Δ
libpysal/graph/_indices.py 65.2% <46.7%> (-34.8%) ⬇️

... and 1 file with indirect coverage changes

@martinfleis martinfleis merged commit 6d8d587 into pysal:main Nov 15, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants