-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standardizing libpysal/weights docs #319
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #319 +/- ##
=======================================
+ Coverage 79.9% 80.0% +0.1%
=======================================
Files 122 122
Lines 13225 13275 +50
=======================================
+ Hits 10563 10614 +51
+ Misses 2662 2661 -1
|
@sjsrey All tests green again. |
* TEST: add 3.11 and shapely_dev coverage * TEST: fix environment-file list * TEST: remove option numba * Update ci/311_shapely_dev.yaml Co-authored-by: Martin Fleischmann <[email protected]> --------- Co-authored-by: James Gaboardi <[email protected]> Co-authored-by: Martin Fleischmann <[email protected]>
7ebc25e
to
2000cc3
Compare
I have no clue how to review this beast. @jGaboardi I know it is late now but it would be better to split changes of docstrings from blackening the code to different PRs to know what to look for in the review. This is just impossible to review at this point. Are there any changes to look for? Anything code-related that is not linting? |
Yeah, this thing got a tad unwieldy over the years. I will looking into splitting it up as time permits. Probably start with |
Okay. Try to split black and ruff into different PRs. Ruff tends to involve code changes that need review while black can be merged directly. |
Yep, that was my plan. Maybe even ruff only 1 or 2 files at a time depending on the amount of changes made. |
You will have to do ruff for the whole codebase to make it pass CI |
This PR focuses on standardizing the
libpysal/weights/*
docs. See #290, #291, pysal/pysal#1174.@sjsrey This is ready for review. It is 95% docstring standardization and 5% logic/code streaming. I have also added several functions to the api docs that had been left out earlier.
Shall I rebuild the actual doc
html
files or leave that until #290 is fully complete (or even next release)?