Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move default musllinux build to musllinux_1_2 #1817

Merged
merged 2 commits into from
May 11, 2024

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented May 10, 2024

Statistics for musl (mostly Alpine but also some OpenWRT)

BigQuery sql query:

SELECT
  details.distro.name as distro_name,
  details.distro.version as distro_version,
  details.distro.libc.lib as libc_name,
  details.distro.libc.version as libc_version,
  COUNT(*) as download_count,
FROM `bigquery-public-data.pypi.file_downloads`
WHERE timestamp BETWEEN TIMESTAMP_ADD(CURRENT_TIMESTAMP(), INTERVAL -6 DAY) AND TIMESTAMP_ADD(CURRENT_TIMESTAMP(), INTERVAL -1 DAY)
  AND details.installer.name = "pip"
  AND details.system.name = "Linux"
  AND file.filename LIKE "%musllinux%"
  AND (details.distro.libc.lib IS NULL OR details.distro.libc.lib != "glibc")
GROUP BY
  distro_name, distro_version, libc_name, libc_version
ORDER BY
  download_count DESC
LIMIT 100

Once reduced, this gives:

version percentage
musllinux_1_2 97.5 %
musllinux_1_1 2.5 %

If we omit the filter on musllinux wheel downloads, this gives:

version percentage
musllinux_1_2 90.5 %
musllinux_1_1 9.5 %

It's worth noting that musl libc 1.1 is EOL and Alpine Linux 3.12 also (support ended 2 years ago, 01 May 2022)

@mayeut mayeut marked this pull request as ready for review May 11, 2024 07:48
@henryiii
Copy link
Contributor

I'd like to add config examples too, I can do it or you. At https://cibuildwheel.pypa.io/en/stable/options/#examples_12.

@henryiii henryiii merged commit c021744 into pypa:main May 11, 2024
19 checks passed
@mayeut mayeut deleted the musllinux_1_2 branch May 11, 2024 21:30
@radarhere
Copy link
Contributor

Be aware there's a typo at https://github.com/pypa/cibuildwheel/releases/tag/v2.18.0

Musllinux now defaults to musllinux_1_2. You can set the older manylinux_1_1 via config if needed. (#1817)

I expect it should say 'the older musllinux_1_1'

@henryiii
Copy link
Contributor

Thanks! Fixed in the GH release and docs fix in #1823.

@EwoutH
Copy link
Contributor

EwoutH commented Aug 26, 2024

How should we handle manylinux dropping support for musllinux_1_1 images on 2024-11-01?

@henryiii
Copy link
Contributor

Same way for the others (manylinux1, manylinux2010, manylinux_2_24), the images just stop updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants