Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor spec spectrum #334

Merged
merged 8 commits into from
Sep 15, 2023
Merged

Refactor spec spectrum #334

merged 8 commits into from
Sep 15, 2023

Conversation

ap--
Copy link
Contributor

@ap-- ap-- commented Aug 29, 2023

This PR addresses the issue described in #333.

  • provides a caching mechanism based on obo version for OboTranslator
  • allows Spectrum and Chromatogram to be instantiated with a obo_version as kwarg

Closes #333

@fu
Copy link
Member

fu commented Aug 30, 2023

As starter - I think you need to black your code :) I will disable or fix the SonarCloud

@ap--
Copy link
Contributor Author

ap-- commented Aug 30, 2023

Done! 😃

The pre-commit config in the repo points to black==18.9b0 the tox "format" env with custom black config is commented out, and the CI uses black<23.
Running black<23 with python3.8 locally, produces changes in other files too though.

To pass the CI checks, I pushed black fixes for the files I changed for now.

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@StSchulze StSchulze merged commit c95d4a6 into pymzml:dev Sep 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor pymzml.spec.Spectrum
5 participants